Remove unused component_graph parameter in LogicalMeter.__init__ - #374
Merged
sahas-subramanian-frequenz merged 1 commit intoMay 5, 2023
Conversation
github-actions
Bot
added
part:data-pipeline
daniel-zullo-frequenz
left a comment
daniel-zullo-frequenz
left a comment
Contributor
There was a problem hiding this comment.
I think this needs an entry in the release notes as it changes the interface of the LogicalMeter. LGTM otherwise
matthias-wende-frequenz
previously approved these changes
May 5, 2023
matthias-wende-frequenz
left a comment
matthias-wende-frequenz
left a comment
Contributor
There was a problem hiding this comment.
Approved apart from mentioning in a changelog entry (as mentioned by Dani)
Signed-off-by: Sahas Subramanian <sahas.subramanian@frequenz.com>
sahas-subramanian-frequenz
force-pushed
the
logical-meter-params
branch
from
May 5, 2023 10:16
446b054 to
d0f3c1a
Compare
sahas-subramanian-frequenz
requested review from
daniel-zullo-frequenz and
matthias-wende-frequenz
May 5, 2023 10:16
daniel-zullo-frequenz
approved these changes
May 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.